Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ b7bf6c16 #48

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Sync with react.dev @ b7bf6c16 #48

merged 10 commits into from
Sep 26, 2024

Conversation

react-translations-bot
Copy link
Collaborator

This PR was automatically generated.

Merge changes from react.dev at b7bf6c1

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

HomyeeKing and others added 8 commits May 6, 2024 10:47
Change the tense of "build" to "building".
* Update synchronizing-with-effects.md

Currently documentation says:

By default, your Effect will run after every render.

Which is in contrast with another section of the same page where it says:

Effects run at the end of a commit after the screen updates

* Update src/content/learn/synchronizing-with-effects.md

---------

Co-authored-by: Ricky <[email protected]>
* Fix #6854: node.js version upgrade

* Fix #6854: node.js version update
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.15 KB (🟡 +260 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 81.1 KB (🟡 +1.36 KB) 185.25 KB
/500 81.1 KB (🟡 +1.36 KB) 185.25 KB
/[[...markdownPath]] 82.94 KB (🟡 +1.42 KB) 187.09 KB
/errors 81.31 KB (🟡 +1.39 KB) 185.46 KB
/errors/[errorCode] 81.29 KB (🟡 +1.39 KB) 185.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@harshilparmar harshilparmar merged commit cba53de into main Sep 26, 2024
2 of 3 checks passed
@harshilparmar harshilparmar deleted the sync-b7bf6c16 branch September 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants