Skip to content

Commit c862996

Browse files
committed
fix(select): pass event as first argument in onchange handlers
1 parent d372912 commit c862996

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/components/Slider/Slider.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -349,10 +349,10 @@ const Slider = React.forwardRef(function Slider(props, ref) {
349349
setFocusVisible(true);
350350

351351
if (onChange) {
352-
onChange(newValue);
352+
onChange(event, newValue);
353353
}
354354
if (onChangeCommitted) {
355-
onChangeCommitted(newValue);
355+
onChangeCommitted(event, newValue);
356356
}
357357
});
358358

@@ -396,7 +396,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
396396
setFocusVisible(true);
397397

398398
if (onChange) {
399-
onChange(newValue);
399+
onChange(event, newValue);
400400
}
401401
});
402402
const handleTouchEnd = useEventCallback(event => {
@@ -409,7 +409,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
409409
const newValue = getNewValue(finger);
410410

411411
if (onChangeCommitted) {
412-
onChangeCommitted(newValue);
412+
onChangeCommitted(event, newValue);
413413
}
414414

415415
touchId.current = undefined;
@@ -434,7 +434,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
434434
setFocusVisible(true);
435435

436436
if (onChange) {
437-
onChange(newValue);
437+
onChange(event, newValue);
438438
}
439439
const doc = ownerDocument(sliderRef.current);
440440
doc.addEventListener('mousemove', handleTouchMove);
@@ -456,7 +456,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
456456
setFocusVisible(true);
457457

458458
if (onChange) {
459-
onChange(newValue);
459+
onChange(event, newValue);
460460
}
461461

462462
const doc = ownerDocument(sliderRef.current);

src/components/Slider/Slider.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,8 @@ describe('<Slider />', () => {
332332
);
333333

334334
expect(handleChange).toHaveBeenCalledTimes(2);
335-
expect(handleChange.mock.calls[0][0]).toBe(80);
336-
expect(handleChange.mock.calls[1][0]).toBe(78);
335+
expect(handleChange.mock.calls[0][1]).toBe(80);
336+
expect(handleChange.mock.calls[1][1]).toBe(78);
337337
});
338338
});
339339

0 commit comments

Comments
 (0)