Skip to content

Commit d372912

Browse files
committed
fix(tab): pass event to onclick handler
pass event as first argument, and value as second argument to onclick handler
1 parent 92bd22e commit d372912

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/components/Tab/Tab.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const Tab = React.forwardRef(function Tab(props, ref) {
6565
<StyledTab
6666
selected={selected}
6767
aria-selected={selected}
68-
onClick={() => onClick(value)}
68+
onClick={e => onClick(e, value)}
6969
role='tab'
7070
ref={ref}
7171
{...otherProps}

src/components/Tabs/Tabs.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('<Tabs />', () => {
6161

6262
fireEvent.click(getAllByRole('tab')[1]);
6363
expect(handleChange).toBeCalledTimes(1);
64-
expect(handleChange).toHaveBeenCalledWith(1);
64+
expect(handleChange.mock.calls[0][1]).toBe(1);
6565
});
6666
});
6767
});

src/components/Tabs/Tabs.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const Default = () => {
5151
activeTab: 0
5252
});
5353

54-
const handleChange = value => setState({ activeTab: value });
54+
const handleChange = (e, value) => setState({ activeTab: value });
5555

5656
const { activeTab } = state;
5757
return (

0 commit comments

Comments
 (0)