Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages router #13

Closed
wants to merge 9 commits into from
Closed

Pages router #13

wants to merge 9 commits into from

Conversation

mayank1513
Copy link
Member

Create an example for next.js pages router.

Why?

  • For some strange reason, this library was failing when using pages router.
  • Found that default export from r18gs was not linked well when using pages router.
  • Attempted with alpha version with named export -> It works well

@mayank1513 mayank1513 self-assigned this Jun 17, 2024
This commit fixes the style issues introduced in f6bbe50 according to the output
from Prettier.

Details: #13
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2a056c3) to head (e0c9593).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          247       247           
  Branches        32        32           
=========================================
  Hits           247       247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Jun 17, 2024

Here's the code health analysis summary for commits e3ab692..e0c9593. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 3 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@mayank1513 mayank1513 closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant