Skip to content

Cover devtoolsruntimesettings with Stable API guards #58131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Cover devtoolsruntimesettings with Stable API guards #58131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/devtoolsruntimesettings/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ add_library(devtoolsruntimesettings OBJECT ${devtoolsruntimesettings_SRCS})

target_include_directories(devtoolsruntimesettings PUBLIC .)

target_link_libraries(devtoolsruntimesettings jsi react_codegen_rncore)
target_link_libraries(devtoolsruntimesettings jsi react_codegen_rncore react_cxxstableapi)
target_compile_reactnative_options(devtoolsruntimesettings PRIVATE)
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>

namespace facebook::react {
Expand Down
Loading