Skip to content

Cover the mutation observer modules with Stable API guards (#58126) #58126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cover the mutation observer modules with Stable API guards (#58126) #58126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/nativemodule/mutationobserver/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ target_include_directories(react_nativemodule_mutationobserver PUBLIC ${REACT_CO

target_link_libraries(react_nativemodule_mutationobserver
react_codegen_rncore
react_cxxstableapi
react_renderer_bridging
react_renderer_core
react_renderer_uimanager
Expand Down
2 changes: 2 additions & 0 deletions ...ges/react-native/ReactCommon/react/nativemodule/mutationobserver/NativeMutationObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
#include "FBReactNativeSpecJSI.h"
#else
Expand Down
1 change: 1 addition & 0 deletions ...eactCommon/react/nativemodule/mutationobserver/React-mutationobservernativemodule.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Pod::Spec.new do |s|
s.dependency "React-Fabric/bridging"
s.dependency "React-Fabric/observers/mutation"
s.dependency "React-featureflags"
s.dependency "React-cxxstableapi"
add_dependency(s, "React-RCTFBReactNativeSpec")
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/observers/mutation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ target_include_directories(react_renderer_observers_mutation PUBLIC ${REACT_COMM

target_link_libraries(react_renderer_observers_mutation
react_cxxreact
react_cxxstableapi
react_renderer_core
react_renderer_uimanager
react_renderer_mounting
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/observers/mutation/MutationObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/components/root/RootShadowNode.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/core/ShadowNodeFamily.h>
Expand Down
2 changes: 2 additions & 0 deletions ...ages/react-native/ReactCommon/react/renderer/observers/mutation/MutationObserverManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/mounting/ShadowTree.h>
#include <react/renderer/uimanager/UIManager.h>
Expand Down
Loading