Exclude React Native native build output by default - #1925
Conversation
|
Hi @kkkhs! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thanks, and I agree with the goal, but React Native-specific config should be in |
Summary
Fixes #1915 by adding Metro's default exclusions for React Native native build outputs that should not be watched:
.cxx, Android Gradle/build directories, iOS build output, and iOS DerivedData.Changelog: [Fix] Exclude React Native native build output from Metro's default file map
Test plan
npx -y yarn@1.22.22 jest packages/metro-config/src/defaults/__tests__/exclusionList-test.js --runInBandnpx eslint packages/metro-config/src/defaults/exclusionList.js packages/metro-config/src/defaults/__tests__/exclusionList-test.js --cachenpx prettier --check packages/metro-config/src/defaults/exclusionList.js packages/metro-config/src/defaults/__tests__/exclusionList-test.jsgit diff --checkyarn run typecheckcould not run locally because the Flow binary requires GLIBC_2.29+ on this host.