Skip to content

Exclude React Native native build output by default - #1925

Closed
kkkhs wants to merge 1 commit into
react:mainfrom
kkkhs:agent/block-native-build-output-1915
Closed

Exclude React Native native build output by default#1925
kkkhs wants to merge 1 commit into
react:mainfrom
kkkhs:agent/block-native-build-output-1915

Conversation

@kkkhs

@kkkhs kkkhs commented Sep 11, 2026

Copy link
Copy Markdown

Summary

Fixes #1915 by adding Metro's default exclusions for React Native native build outputs that should not be watched: .cxx, Android Gradle/build directories, iOS build output, and iOS DerivedData.

Changelog: [Fix] Exclude React Native native build output from Metro's default file map

Test plan

  • npx -y yarn@1.22.22 jest packages/metro-config/src/defaults/__tests__/exclusionList-test.js --runInBand
  • npx eslint packages/metro-config/src/defaults/exclusionList.js packages/metro-config/src/defaults/__tests__/exclusionList-test.js --cache
  • npx prettier --check packages/metro-config/src/defaults/exclusionList.js packages/metro-config/src/defaults/__tests__/exclusionList-test.js
  • git diff --check

yarn run typecheck could not run locally because the Flow binary requires GLIBC_2.29+ on this host.

@meta-cla

meta-cla Bot commented Sep 11, 2026

Copy link
Copy Markdown

Hi @kkkhs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@robhogan

Copy link
Copy Markdown
Collaborator

Thanks, and I agree with the goal, but React Native-specific config should be in @react-native/metro-config.

@robhogan robhogan closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FallbackWatcher: #unregisterDir rescans the whole directory registry per unlink, stalling the dev server on Windows

2 participants