Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

EndCall fix #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eugenehp
Copy link

@eugenehp eugenehp commented May 3, 2017

@ianlin
Copy link
Collaborator

ianlin commented May 5, 2017

Hey @eugenehp thanks for this.

In my case using either action.UUID or action.callUUID works as expected. From the log output the value of action.UUID is different from that of action.callUUID while action.callUUID is identical to the uuid I pass when calling startCall react method.

This is a bit weird.. Can you please share some information about your environment like the iOS version and how you use this module?

Thanks!

@joshuaalpuerto
Copy link

Hi @ianlin , this PR works for this issue. #3 Hope this one will be merge soon.

@sujameslin
Copy link
Contributor

@eugenehp Can you please resolve conflict?

@aarkalyk
Copy link
Contributor

aarkalyk commented Feb 23, 2018

According to the apple doc UUID in reportCallWithUUID:(NSUUID *)UUID is

The unique identifier of the call.

Whereas, UUID of CXAction object is

The unique identifier for the action.

and callUUID of CXCallAction object is

The unique identifier for the call associated with the action.

I believe we should stick to the current version where we pass startCallAction.callUUID.

@eugenehp @ianlin @sujameslin Guys, can we close this one?

@zek
Copy link

zek commented Oct 18, 2018

That needs to be merged. I have also same issue #3 . It is not closed and after a while I am getting "CALL FAILED" message.

Lukkub pushed a commit to Experty/react-native-callkit that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants