Don't try to get phone account if self managed when creating a connection

[donaldkwong]

We want to use CallKeep without requesting READ_PHONE_STATE permissions on Android, which should be possible if we're in self managed state. However, the connection creation code in VoiceConnectionService always tries to get the phone account, which requires that permission to be granted. This diff adds a check to see if we're in self managed mode and, if so, don't try to get the phone account.

[wilmxre]

@donaldkwong hey man, why did you close this PR?

[manuquentin]

Thanks @donaldkwong, can you add a little bit of documentation for this behaviour ?

[donaldkwong]

@manuquentin , what were you thinking of in terms of documentation? Changes to README.md or code comments?

[manuquentin]

Can you put changes in the README please ?

[donaldkwong]

Honestly not sure what to write in the README since this feels more like a bug fix than a feature, but I added a description of the behavior.

[donaldkwong]

I don't have permission to merge this PR. Can someone do it for me?

[Bayramito]

We want to use CallKeep without requesting READ_PHONE_STATE permissions on Android, which should be possible if we're in self managed state. However, the connection creation code in VoiceConnectionService always tries to get the phone account, which requires that permission to be granted. This diff adds a check to see if we're in self managed mode and, if so, don't try to get the phone account.

hey @donaldkwong is this going to help me to use some functions in android without calling setup, functions like setAudioRoute ?