Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android build errors with RN 0.74 #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramijarrar
Copy link
Contributor

@ramijarrar ramijarrar commented Apr 15, 2023

After updating to React Native 0.71, we are getting build failures on Android (including #646).

This PR makes the following changes to resolve these:

  • Add redundant handling for missing permission exceptions. Existing checks work but
    do not satisfy lint, so this is the only way to resolve Call requires permission which may be rejected by user #646

  • Upgrade gradle to maximum compatible version (3.6.4) to satisfy new minimum (3.2.0)

  • Use AudioManager.MODE_NORMAL constant explicitly (instead of the equivalent value of
    "0" currently being used) to satisfy lint

  • Replace deprecated WindowManager.LayoutParams constants with Activity API methods
    when using Android SDK v27+

@santhoshvai
Copy link

@saghul please review this

@saghul
Copy link
Member

saghul commented Jun 5, 2023

Sorry I'm not familiar enough with this project to give a proper review.

Personally, bumping the minimum SDK to 27 sounds like it would leave too many users out.

- Add redundant handling for missing permission exceptions. Existing checks work but
  do not satisfy lint, so this is the only way to resolve react-native-webrtc#646

- Upgrade gradle to maximum compatible version (3.6.4) to satisfy new minimum (3.2.0)

- Use AudioManager.MODE_NORMAL constant explicitly (instead of the equivalent value of
  "0" currently being used) to satisfy lint

- Replace deprecated WindowManager.LayoutParams constants with Activity API methods
  when using Android SDK v27+
@ramijarrar
Copy link
Contributor Author

ramijarrar commented Oct 31, 2023

@manuquentin I've updated the PR to maintain compatibility with older platform versions.

@ramijarrar
Copy link
Contributor Author

@manuquentin Can you please advise if there any further changes you would like to get this merged? Thanks!

@ramijarrar ramijarrar changed the title Fix android build errors with RN 0.71 Fix android build errors with RN 0.74 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call requires permission which may be rejected by user
3 participants