-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native callback for call rejects #423
base: master
Are you sure you want to change the base?
Native callback for call rejects #423
Conversation
@sboily hey, could you review once more |
@remigijusbalc could you help me create an event for cancel a call. My context is when a call is coming and then user press wake/sleep button in order to cancel a call. I really need that event |
@khanhduy62 till this PR gets a review, you could just fork my repo and use it like this: [RNCallKeep setup:@{
}]; |
@remigijusbalc thank you, let me check it :D |
@manuquentin Hey, could you check this out? |
@manuquentin any feedback? Looks good to me. |
@sboily @manuquentin Any update on this. required feature, if possible please release a new version with this. |
Hello @hussainsherwani, sorry we are quite busy for the moment, but yeah we will review it as soon as possible. |
@remigijusbalc I tried with your fork , I am getting an error, could you please help me out |
@hussainsherwani my fork has another feature - to cancel calls and it's not submitted as PR. You can ignore it by passing "isCancelEvent: NO" to reportNewIncomingCall method in your AppDelegate didReceiveIncomingPushWithPayload method. |
@remigijusbalc Thanks for the quick reply, I tried to add |
Try reinstalling node_modules and pods, then checkouting to this PR commit |
@remigijusbalc Thanks, It was my mistake build successfully, |
@remigijusbalc could you please help me in one more thing how can I get my notification payload when a call decline as it only give a |
@hussainsherwani You could simply save payload in your AppDelegate defined dictionary based on uuid and on callReject callback use it |
hello @remigijusbalc with your forked repo android app not working, getting error |
Hey @remigijusbalc & @hussainsherwani, |
hey @linus-komnick for me rejection event fire immediately I am using this but in @remigijusbalc forked repo there is an issue for android so when I create android build I use library package for IOS I use forked repo |
@hussainsherwani thx, I will take note of that! |
@hussainsherwani In my app the rejection event fires immediately when receiving a voip/pushkit notification. But not when canceling the call. For you it's the other way around, right? |
@remigijusbalc can you please update the PR as there is now a conflict |
Hey, @remigijusbalc just to confirm, does this PR solves the issue of not triggering the endCall when the call is rejected when a user presses the reject button in the incoming call? Basically what happens currently is that when a call is rejected through the incoming call the endCall event is triggered which seems weird. So, there's no way of handling the reject call. I have a usecase where the reject call and hangup button should trigger different WS events. But here in both the scenarios, the endCall event is triggered. |
any update on this? |
This callback helps in cases when JS context is not loaded and call rejection have to be instantly reported to backend