Make API much closer to lottie-react-native and add types
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uragirii
changed the title
uragirii
changed the title
lottie-react-native and add types
shcoderAlex
approved these changes
Oct 30, 2022
mateoguzmana
approved these changes
Nov 7, 2022
gomes042
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the API much more closer to
lottie-react-nativepackage as it is supposed to be used alongside that. Following things are addedsupport for loading lottie files from a remote url. The
sourceprop accepts{uri: <remote url string>}. This support was previously missing. We first check if the remote url is provided, if not fallback to using object as animation data.Add support for animation speed. This fixes Changing
speedprop has no effect #27Adds types for the projects. The types are copied from types of
lottie-react-native