feat(voice): Improve null handling and add local development docs #560
+161
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two main improvements: 1. **Bug Fix (Android):** Addresses a critical bug in the Android native module where the `onResults` function would crash if the speech recognizer returned null or empty results. The implementation now includes a robust check to validate the results. If they are null or empty, it sends an empty array to the JavaScript layer, preventing crashes and ensuring application stability. 2. **Documentation:** Adds a detailed guide (`docs/LOCAL_DEVELOPMENT.md`) explaining the step-by-step process for compiling, packaging, and testing the library locally in a React Native project. The main README has been updated to reference this new guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two main improvements:
Bug Fix (Android): Addresses a critical bug in the Android native module where the
onResultsfunction would crash if the speech recognizer returned null or empty results. The implementation now includes a robust check to validate the results. If they are null or empty, it sends an empty array to the JavaScript layer, preventing crashes and ensuring application stability.Documentation: Adds a detailed guide (
docs/LOCAL_DEVELOPMENT.md) explaining the step-by-step process for compiling, packaging, and testing the library locally in a React Native project. The main README has been updated to reference this new guide.