Skip to content

Conversation

@saseungmin
Copy link
Member

@saseungmin saseungmin commented Aug 26, 2025

  • TSDoc specifies the tag name as @remarks (not @remark).
  • This aligns our comments with the spec and improves tooling support.
  • No runtime behavior changes.
  • Ref: https://tsdoc.org/pages/tags/remarks/

Summary by CodeRabbit

  • Documentation

    • Updated inline documentation to use the TSDoc-compliant @remarks tag for multiple properties across core and React Native packages.
    • Clarified docs for autoplay, controls, playsinline, rel, origin, useInlineHtml, and webViewUrl, with a spec reference link.
    • No API or runtime behavior changes.
  • Chores

    • Published patch version bumps for react-native-youtube-bridge and @react-native-youtube-bridge/core.

- TSDoc specifies the tag name as `@remarks` (not `@remark`).
- This aligns our comments with the spec and improves tooling support.
- No runtime behavior changes.
- Ref: https://tsdoc.org/pages/tags/remarks/
@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2025

🦋 Changeset detected

Latest commit: a90d70a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-native-youtube-bridge Patch
@react-native-youtube-bridge/core Patch
@react-native-youtube-bridge/react Patch
@react-native-youtube-bridge/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Aug 26, 2025

Walkthrough

Patch changeset added for two packages and TSDoc tags updated from @remark to @remarks in type definitions. No code logic, signatures, or runtime behavior changed.

Changes

Cohort / File(s) Summary
Changeset bump
./.changeset/funny-baths-carry.md
Adds a patch changeset for react-native-youtube-bridge and @react-native-youtube-bridge/core; notes TSDoc tag adjustment.
Core types TSDoc updates
packages/core/src/types/index.ts
Replaces @remark with @remarks in YoutubePlayerVars docs (autoplay, controls, playsinline, rel, origin). No API changes.
RN bridge types TSDoc updates
packages/react-native-youtube-bridge/src/types/youtube.ts
Replaces @remark with @remarks in YoutubeViewProps docs (useInlineHtml, webViewUrl). No API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

I thump my paws: remarks, not remark!
Tiny tags align, precise and stark.
No code to run, no logic bends—
Just tidy docs where clarity trends.
Patch hops shipped—hip hop, hark! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/tsdoc-remarks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

Deploying react-native-youtube-bridge-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: a90d70a
Status: ✅  Deploy successful!
Preview URL: https://27792d33.react-native-youtube-bridge-example.pages.dev
Branch Preview URL: https://docs-tsdoc-remarks.react-native-youtube-bridge-example.pages.dev

View logs

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/funny-baths-carry.md (1)

6-11: Fix bare URL in changeset to satisfy markdownlint (MD034)

Wrap the reference link to avoid “Bare URL used”.

Apply this patch:

- - Ref: https://tsdoc.org/pages/tags/remarks/
+ - Ref: <https://tsdoc.org/pages/tags/remarks/>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9bf20 and a90d70a.

📒 Files selected for processing (3)
  • .changeset/funny-baths-carry.md (1 hunks)
  • packages/core/src/types/index.ts (2 hunks)
  • packages/react-native-youtube-bridge/src/types/youtube.ts (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
packages/react-native-youtube-bridge/src/types/youtube.ts (3)
packages/react-native-youtube-bridge/src/YoutubeView.tsx (2)
  • YoutubeView (16-189)
  • useInlineHtml (41-57)
packages/react-native-youtube-bridge/src/YoutubeView.web.tsx (1)
  • YoutubeView (9-92)
packages/web/src/YoutubePlayer.tsx (1)
  • YoutubePlayer (11-237)
packages/core/src/types/index.ts (4)
packages/web/src/YoutubePlayer.tsx (1)
  • YoutubePlayer (11-237)
packages/core/src/WebYoutubePlayerController.ts (1)
  • WebYoutubePlayerController (10-377)
packages/react-native-youtube-bridge/src/YoutubeView.web.tsx (1)
  • YoutubeView (9-92)
packages/react-native-youtube-bridge/src/hooks/useCreateLocalPlayerHtml.ts (1)
  • YoutubePlayerVars (6-212)
🪛 markdownlint-cli2 (0.17.2)
.changeset/funny-baths-carry.md

11-11: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (6)
packages/core/src/types/index.ts (4)

121-127: Swapped to @remarks — looks good for autoplay docs

Change aligns with TSDoc spec, no API/runtime impact.


128-135: Controls: @remarks tag update is correct

Spec-compliant and keeps intent clear.


155-160: Playsinline: @remarks usage is correct

Reads well and matches platform guidance.


171-175: Origin: @remarks tag update looks good

The bullet points are clear and consistent with how origin/baseUrl are consumed elsewhere.

packages/react-native-youtube-bridge/src/types/youtube.ts (2)

45-51: useInlineHtml: @remarks update is correct

Spec-compliant; description remains accurate.


55-64: webViewUrl: @remarks update is correct

Guidance on baseUrl vs origin and trailing slash is clear.

Comment on lines +163 to 166
* @remarks
* After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false, related videos will come from the same channel as the video that was just played.
*/
rel?: boolean;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix backtick typo in “rel” documentation

There’s an unclosed inline code fence around false, which can break formatting in generated docs.

Apply this patch:

- * After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false, related videos will come from the same channel as the video that was just played.
+ * After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false`, related videos will come from the same channel as the video that was just played.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* @remarks
* After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false, related videos will come from the same channel as the video that was just played.
*/
rel?: boolean;
* @remarks
* After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false`, related videos will come from the same channel as the video that was just played.
*/
rel?: boolean;
🤖 Prompt for AI Agents
In packages/core/src/types/index.ts around lines 163 to 166, the JSDoc for `rel`
contains an unclosed inline code fence around false which breaks formatting in
generated docs; fix it by wrapping false in backticks (`false`) so the sentence
reads "...if the `rel` parameter is set to `false`, related videos..." and
ensure punctuation spacing remains correct.

@saseungmin saseungmin merged commit 390538e into main Aug 26, 2025
5 checks passed
@saseungmin saseungmin deleted the docs/tsdoc-remarks branch August 26, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants