Skip to content

chore(deps-dev): bump react-dom and @types/react-dom #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+19 −24
Closed

chore(deps-dev): bump react-dom and @types/react-dom #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@
"@testing-library/react-hooks": "^8.0.1",
"@types/js-cookie": "^3.0.6",
"@types/react": "^17.0.83",
"@types/react-dom": "^17.0.26",
"@types/react-dom": "^19.0.3",
"@vitest/coverage-v8": "^3.0.5",
"commitlint": "^19.7.1",
"eslint": "^9.20.1",
@@ -75,7 +75,7 @@
"lint-staged": "^15.4.3",
"pinst": "^3.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-dom": "^19.0.0",
"rimraf": "^6.0.1",
"semantic-release": "^24.2.2",
"typescript": "^5.7.3",
39 changes: 17 additions & 22 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -1286,7 +1286,7 @@ __metadata:
"@testing-library/react-hooks": "npm:^8.0.1"
"@types/js-cookie": "npm:^3.0.6"
"@types/react": "npm:^17.0.83"
"@types/react-dom": "npm:^17.0.26"
"@types/react-dom": "npm:^19.0.3"
"@vitest/coverage-v8": "npm:^3.0.5"
commitlint: "npm:^19.7.1"
eslint: "npm:^9.20.1"
@@ -1296,7 +1296,7 @@ __metadata:
lint-staged: "npm:^15.4.3"
pinst: "npm:^3.0.0"
react: "npm:^17.0.2"
react-dom: "npm:^17.0.2"
react-dom: "npm:^19.0.0"
rimraf: "npm:^6.0.1"
semantic-release: "npm:^24.2.2"
typescript: "npm:^5.7.3"
@@ -1822,12 +1822,12 @@ __metadata:
languageName: node
linkType: hard

"@types/react-dom@npm:^17.0.26":
version: 17.0.26
resolution: "@types/react-dom@npm:17.0.26"
"@types/react-dom@npm:^19.0.3":
version: 19.0.3
resolution: "@types/react-dom@npm:19.0.3"
peerDependencies:
"@types/react": ^17.0.0
checksum: 10c0/8363921f08afe3f2ef82fe293301a0809ec646975fe9f5bfeb2e823f7237b97e47d27e1c6c2ffff27d15c12ab3cad1de6c77a737e37499fcc52793b0fd674f3f
"@types/react": ^19.0.0
checksum: 10c0/3867427b333cbe8cbba496d7cc20ec9676d32c25ae44f4d1263a4129d42e57cf4adf0039ad263432f1215b88075c27d326e7eb4ed646128235d01a76e661d48f
languageName: node
linkType: hard

@@ -8432,16 +8432,14 @@ __metadata:
languageName: node
linkType: hard

"react-dom@npm:^17.0.2":
version: 17.0.2
resolution: "react-dom@npm:17.0.2"
"react-dom@npm:^19.0.0":
version: 19.0.0
resolution: "react-dom@npm:19.0.0"
dependencies:
loose-envify: "npm:^1.1.0"
object-assign: "npm:^4.1.1"
scheduler: "npm:^0.20.2"
scheduler: "npm:^0.25.0"
peerDependencies:
react: 17.0.2
checksum: 10c0/51abbcb72450fe527ebf978c3bc989ba266630faaa53f47a2fae5392369729e8de62b2e4683598cbe651ea7873cd34ec7d5127e2f50bf4bfe6bd0c3ad9bddcb0
react: ^19.0.0
checksum: 10c0/a36ce7ab507b237ae2759c984cdaad4af4096d8199fb65b3815c16825e5cfeb7293da790a3fc2184b52bfba7ba3ff31c058c01947aff6fd1a3701632aabaa6a9
languageName: node
linkType: hard

@@ -8971,13 +8969,10 @@ __metadata:
languageName: node
linkType: hard

"scheduler@npm:^0.20.2":
version: 0.20.2
resolution: "scheduler@npm:0.20.2"
dependencies:
loose-envify: "npm:^1.1.0"
object-assign: "npm:^4.1.1"
checksum: 10c0/b0982e4b0f34f4ffa4f2f486161c0fd9ce9b88680b045dccbf250eb1aa4fd27413570645455187a83535e2370f5c667a251045547765408492bd883cbe95fcdb
"scheduler@npm:^0.25.0":
version: 0.25.0
resolution: "scheduler@npm:0.25.0"
checksum: 10c0/a4bb1da406b613ce72c1299db43759526058fdcc413999c3c3e0db8956df7633acf395cb20eb2303b6a65d658d66b6585d344460abaee8080b4aa931f10eaafe
languageName: node
linkType: hard

Unchanged files with check annotations Beta

View file
src/useAsync/index.dom.test.ts
});
it('should render', () => {
const {result} = renderHook(() => useAsync(async () => true));

Check failure on line 29 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should render 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:29:20
expect(result.error).toBeUndefined();
});
it('should not invoke async function on mount if `skipMount` option is passed', () => {
const spy = vi.fn(async () => {});
renderHook(() => useAsync(spy));

Check failure on line 35 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should not invoke async function on mount if `skipMount` option is passed 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:35:3
expect(spy).not.toHaveBeenCalled();
});
it('should apply `initialValue` arg', async () => {
await act(async () => {

Check failure on line 41 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should apply `initialValue` arg 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ src/useAsync/index.dom.test.ts:41:9

Check failure on line 41 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

`act` is deprecated. Import `act` from `react` instead. (@typescript-eslint/no-deprecated)

Check failure on line 41 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

Unsafe call of a(n) `error` type typed value. (@typescript-eslint/no-unsafe-call)
const [spy, resolve] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy, 3));
});
it('should have `not-executed` status initially', async () => {
await act(async () => {

Check failure on line 62 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should have `not-executed` status initially 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ src/useAsync/index.dom.test.ts:62:9

Check failure on line 62 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

`act` is deprecated. Import `act` from `react` instead. (@typescript-eslint/no-deprecated)

Check failure on line 62 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

Unsafe call of a(n) `error` type typed value. (@typescript-eslint/no-unsafe-call)
const [spy, resolve] = getControllableAsync<void>();
const {result} = renderHook(() => useAsync(spy));
it('should have `loading` status while promise invoked but not resolved', async () => {
const [spy, resolve] = getControllableAsync<void>();
const {result} = renderHook(() => useAsync(spy));

Check failure on line 80 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should have `loading` status while promise invoked but not resolved 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:80:20
expect(result.current[0]).toStrictEqual({
status: 'not-executed',
result: undefined,
});
await act(async () => {

Check failure on line 88 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

`act` is deprecated. Import `act` from `react` instead. (@typescript-eslint/no-deprecated)

Check failure on line 88 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

Unsafe call of a(n) `error` type typed value. (@typescript-eslint/no-unsafe-call)
void result.current[1].execute();
});
result: undefined,
});
await act(async () => {

Check failure on line 98 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

`act` is deprecated. Import `act` from `react` instead. (@typescript-eslint/no-deprecated)

Check failure on line 98 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

Unsafe call of a(n) `error` type typed value. (@typescript-eslint/no-unsafe-call)
if (resolve.current) {
resolve.current();
}
it('should set `success` status and store `result` state field on fulfill', async () => {
const [spy, resolve] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy));

Check failure on line 107 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should set `success` status and store `result` state field on fulfill 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:107:20
expect(result.current[0]).toStrictEqual({
status: 'not-executed',
result: undefined,
});
await act(async () => {

Check failure on line 115 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

`act` is deprecated. Import `act` from `react` instead. (@typescript-eslint/no-deprecated)

Check failure on line 115 in src/useAsync/index.dom.test.ts

GitHub Actions / Lint 

Unsafe call of a(n) `error` type typed value. (@typescript-eslint/no-unsafe-call)
void result.current[1].execute();
if (resolve.current) {
it('should set `error` status and store `error` state field on reject', async () => {
const [spy, , reject] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy));

Check failure on line 132 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should set `error` status and store `error` state field on reject 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:132:20
expect(result.current[0]).toStrictEqual({
status: 'not-executed',
it('should rollback state to initial on `reset` method call', async () => {
const [spy, resolve] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy, 42));

Check failure on line 159 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should rollback state to initial on `reset` method call 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:159:20
expect(result.current[0]).toStrictEqual({
status: 'not-executed',
it('should not process results of promise if another was executed', async () => {
const [spy, resolve] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy, 42));

Check failure on line 194 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should not process results of promise if another was executed 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:194:20
await act(async () => {
void result.current[1].execute();
it('should not process error of promise if another was executed', async () => {
const [spy, resolve, reject] = getControllableAsync<number>();
const {result} = renderHook(() => useAsync(spy, 42));

Check failure on line 225 in src/useAsync/index.dom.test.ts

GitHub Actions / Test

src/useAsync/index.dom.test.ts > useAsync > should not process error of promise if another was executed 

TypeError: React.act is not a function
 ❯ process.env.NODE_ENV.exports.act node_modules/react-dom/cjs/react-dom-test-utils.development.js:22:20
 ❯ render node_modules/@testing-library/react-hooks/lib/dom/pure.js:79:26
 ❯ renderHook node_modules/@testing-library/react-hooks/lib/core/index.js:114:5
 ❯ src/useAsync/index.dom.test.ts:225:20
await act(async () => {
void result.current[1].execute();