-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new hook useSpeech
#1378
base: master
Are you sure you want to change the base?
feat: new hook useSpeech
#1378
Conversation
@JoeDuncko @xobotyi Please review this PR |
@JoeDuncko @xobotyi Please review this PR |
ill review it sometime this week |
@xobotyi Any update on PR review? |
@xobotyi Any update on review? |
On review - no, tests - failing =) |
@xobotyi Fixed test cases. You can check now. |
@xobotyi Any update on this? |
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
==========================================
- Coverage 99.62% 98.46% -1.17%
==========================================
Files 62 63 +1
Lines 1072 1105 +33
Branches 169 174 +5
==========================================
+ Hits 1068 1088 +20
- Misses 2 12 +10
- Partials 2 5 +3
... and 9 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
youi also have to add the hook to radme. otherwise - looks good |
also linting is failing |
@xobotyi Added hook in readme.md I checked linting but it is not failing. Let me know by which command it is failing. |
You can see linting annotations within files tab of pull request. Linter should be run with |
@xobotyi Fixed linting. You can check now. |
you should also add tests for pausing resuming, etc. you should target 100% coverage and in this case is it easily achievable. |
Hook description
Hook for playing text using the SpeechSynthesis API.
Valid use-case for the hook
Checklist
react-use
, have you checked Port remaining hooks fromreact-use
#33 and the migration guideto confirm that the hook has been approved for porting?
react-use
#33