Skip to content

refactor: Remove legacy api #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

refactor: Remove legacy api #539

merged 1 commit into from
May 14, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 14, 2025

ref https://github.com/react-component/trigger/pull/538/files#r2088353792

用到 getTriggerDOMNode 的地方全部清理干净了,这里可以少一个 createElement(TriggerWrapper)cloneElement(target)

Summary by CodeRabbit

  • 重构
    • 移除了 TriggerWrapper 组件及相关属性,简化了组件结构,减少了中间包装层。
    • 删除了 getTriggerDOMNode 属性,优化了组件接口。

Copy link

coderabbitai bot commented May 14, 2025

Walkthrough

本次更改删除了 src/TriggerWrapper.tsx 文件及其导出的 TriggerWrapper 组件,并在 src/index.tsx 中移除了对该组件的引用和相关的 getTriggerDOMNode 属性。triggerNode 现在直接作为 ResizeObserver 的子元素渲染,简化了组件结构。

Changes

文件/路径 变更摘要
src/TriggerWrapper.tsx 删除了 TriggerWrapper 组件及其类型声明和所有相关实现。
src/index.tsx 移除了 TriggerWrapper 的导入与使用,删除了 getTriggerDOMNode 属性及相关类型定义。

Possibly related PRs

Poem

🐇
触发包装轻轻去,
组件树下更清晰。
引用传递不再绕,
节点观察更直接。
代码精简如春风,
兔子为你跳一跳!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs[email protected][email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb94258 and 2092fa1.

📒 Files selected for processing (2)
  • src/TriggerWrapper.tsx (0 hunks)
  • src/index.tsx (2 hunks)
💤 Files with no reviewable changes (1)
  • src/TriggerWrapper.tsx
🔇 Additional comments (2)
src/index.tsx (2)

638-642: 精简了 triggerNode 的创建逻辑

原来的代码可能使用了 TriggerWrapper 组件来包装 triggerNode,现在直接使用 React.cloneElement 克隆子元素,并传入所需属性。这种方式更加直接,减少了不必要的组件层级,符合 React 性能优化的最佳实践。


652-652: 简化了组件结构

之前的代码可能将 triggerNode 包装在 TriggerWrapper 组件中再渲染到 ResizeObserver 内部,现在直接将 triggerNode 渲染在 ResizeObserver 中,移除了中间层,使组件结构更加清晰。这次重构移除了 getTriggerDOMNode API 的使用,简化了代码并消除了额外的 DOM 节点。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zombieJ zombieJ merged commit 6b17169 into master May 14, 2025
8 checks passed
@zombieJ zombieJ deleted the clean branch May 14, 2025 10:15
@zombieJ zombieJ mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants