-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolved table's unexpected rounded corners #1060
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
照常加个用例,保险点。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 47 47
Lines 4517 4521 +4
Branches 571 571
=======================================
+ Hits 4495 4499 +4
Misses 22 22 ☔ View full report in Codecov by Sentry. |
默认情况下不添加 class,应该 |
另外感觉只要把 border-radius 给 header 就好了,应该不需要额外添加 class? |
他默认是有header吧,所以我的想法就是在showHeader={false} |
看下 snapshot,现在是多了一个 |
是的,因为默认是有那个header然后,他有个圆角的属性在-container里,所以我想分离开来做,就是showheader为false时去掉-header,其他情况保留-header |
我推荐是直接把圆角样式写在 header 上,table 不带圆角,这样去掉 header 的时候就没有圆角了 |
ok,我再看看 |
我尝试的其他解决方案 #46389 |
showHeader=false
andbordered
. ant-design/ant-design#46362 to resolve this issue