Skip to content

fix: adjust father targets from chrome 85 to ie11#7

Merged
fireairforce merged 1 commit intomasterfrom
adjust-father-targets
Mar 17, 2026
Merged

fix: adjust father targets from chrome 85 to ie11#7
fireairforce merged 1 commit intomasterfrom
adjust-father-targets

Conversation

@fireairforce
Copy link
Member

@fireairforce fireairforce commented Mar 17, 2026

solve issue: #5

Because rc father-plugin set target to: chorme 85(which allows class and not downgrade the syntax):

https://github.com/react-component/father-plugin/blob/main/src/index.ts#L70

In this repo just change the target to ie11 to make class syntax downgrade:

image

Summary by CodeRabbit

  • 新功能
    • 添加了对 Internet Explorer 11 浏览器的支持。

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a compatibility issue where class syntax was not being correctly transpiled for older browsers. By updating the father build configuration to explicitly target Internet Explorer 11, the generated code will now include the necessary downgrades, ensuring the component functions as expected across a wider range of environments.

Highlights

  • Build Target Adjustment: Adjusted the father build configuration to target ie11 instead of chrome 85. This change ensures that modern JavaScript syntax, specifically class declarations, is properly downgraded for broader browser compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .fatherrc.js
    • Added a targets configuration object to specify ie: 11 for the build process.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: be890bd5-b7a0-4a64-be2c-e5fdea709f8c

📥 Commits

Reviewing files that changed from the base of the PR and between ebb8580 and 562092f.

📒 Files selected for processing (1)
  • .fatherrc.js

Walkthrough

.fatherrc.js 配置文件中新增了 targets 属性,将 IE 浏览器目标版本指定为 11。此变更通过向 defineConfig 传递的配置对象添加新的顶级属性来扩展配置。

Changes

内聚 / 文件 摘要
配置更新
\.fatherrc\.js
在 Father 构建工具配置中新增 targets 对象,设置 ie: 11,用于指定 IE 浏览器兼容性目标。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 配置添一行,目标指向前,
IE 十一版,兼容无遗憾,
Father 构建时,目的更鲜明,
小小改动里,大大智慧藏! 🎯

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR title clearly summarizes the main change: adjusting Father build configuration targets from Chrome 85 to IE11 to enable class syntax downgrading.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adjust-father-targets
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@github-actions
Copy link

github-actions bot commented Mar 17, 2026

😭 Deploy PR Preview 562092f failed. Build logs

🤖 By surge-preview

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build configuration to target Internet Explorer 11. This is intended to fix an issue where modern JavaScript syntax was not being transpiled for older browsers. The change is functional, but I have provided a suggestion to use a centralized browserslist configuration for better long-term maintainability of browser targets.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.17%. Comparing base (ebb8580) to head (562092f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files           5        5           
  Lines         238      238           
  Branches       70       70           
=======================================
  Hits          217      217           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fireairforce fireairforce merged commit 14d4de3 into master Mar 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants