fix: adjust father targets from chrome 85 to ie11#7
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compatibility issue where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
|
😭 Deploy PR Preview 562092f failed. Build logs 🤖 By surge-preview |
There was a problem hiding this comment.
Code Review
This pull request updates the build configuration to target Internet Explorer 11. This is intended to fix an issue where modern JavaScript syntax was not being transpiled for older browsers. The change is functional, but I have provided a suggestion to use a centralized browserslist configuration for better long-term maintainability of browser targets.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 5 5
Lines 238 238
Branches 70 70
=======================================
Hits 217 217
Misses 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

solve issue: #5
Because rc father-plugin set target to: chorme 85(which allows
classand not downgrade the syntax):https://github.com/react-component/father-plugin/blob/main/src/index.ts#L70
In this repo just change the target to
ie11to makeclasssyntax downgrade:Summary by CodeRabbit