Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix this.unmounted being true when re-mounted by React 18 #480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix this.unmounted being true when re-mounted by React 18 #480

wants to merge 1 commit into from

Commits on Jul 25, 2021

  1. Fix this.unmounted being true when re-mounted by React 

    React 18 can render componentWillUnmount and then componentDidMount the same instance that was just "willUnmount"-ed.
This makes sure we reset `this.unmounted = false` when re-didMount-ing.
    @dralletje
    dralletje authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    6d0433d View commit details
    Browse the repository at this point in the history