fix(connectObservable): fix updates on more than one component

re-rxjs · Jul 14, 2020 · 5b5b138 · 5b5b138
1 parent 9e880c9
commit 5b5b138
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/internal/react-enhancer.ts b/src/internal/react-enhancer.ts
@@ -11,9 +11,9 @@ const reactEnhancer = <T>(
   delayTime: number,
 ): BehaviorObservable<T> => {
   let finalizeLastUnsubscription = noop
-  let latestValue = EMPTY_VALUE
   const result = new Observable<T>(subscriber => {
     let isActive = true
+    let latestValue = EMPTY_VALUE
     const subscription = source$.subscribe({
       next(value) {
         if (
@@ -97,7 +97,6 @@ const reactEnhancer = <T>(
       }
 
       if (value !== EMPTY_VALUE) {
-        latestValue = value
         return (valueResult = { type: "v", payload: value })
       }
 

diff --git a/src/internal/useObservable.ts b/src/internal/useObservable.ts
@@ -8,13 +8,16 @@ const SUSP: "s" = "s"
 type Action = "e" | "v" | "s"
 
 const reducer = (
-  _: { type: Action; payload: any },
+  current: { type: Action; payload: any },
   action: { type: Action; payload: any },
 ) => {
   if (action.type === ERROR) {
     throw action.payload
   }
-  return action
+  return Object.is(current.payload, action.payload) &&
+    current.type === action.type
+    ? current
+    : action
 }
 
 const init = (source$: BehaviorObservable<any>) => source$.getValue()