Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Restructure #40

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Docs Restructure #40

wants to merge 3 commits into from

Conversation

voliva
Copy link
Collaborator

@voliva voliva commented May 6, 2021

This PR will hold most of the changes for the restructe stated in #37

@voliva voliva requested a review from josepot May 6, 2021 21:44

We strongly recommend reading through [core concepts](core-concepts.md) to
understand the mindset of this library.
React-RxJS gets even more fun when you start using asynchronous state, leveraging Suspense and enhancing code-splitting!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure on the casual register I took in here, maybe it's too much. I'd like to make readers keep following the next few examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Comment on lines +1 to +3
---
title: Features
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a section highlighting these few features.... things like TS support, React Native, etc., but I feel this feels a bit empty. Dunno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants