CI: Eliminate duplicate workflow runs from Pull Requests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous configuration would trigger two runs when changes were made to PRs. That's hugely wasteful, increases the time-to-feedback, and simply not useful in the slightest.
rdw-software
force-pushed
the
54-duplicate-workflow-runs
branch
from
b42a1f3
to
0055c5c
Compare
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this as part of #130 and #142 , even if it's not really related to the changes.
The previous configuration would trigger two runs when changes were made to PRs. That's hugely wasteful, increases the time-to-feedback, and simply not useful in the slightest.
Update: It actually only triggers the duplicate runs when the PRs are merged (on the merge commit), but the same reasoning holds.