This repository has been archived by the owner on Nov 5, 2020. It is now read-only.
[WiP] 2.0 Branch #47
Open
[WiP] 2.0 Branch #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid having the Rule object violate Single Responsibility Filtering and Annotation were separated. The actual filter action is now in the "Filters" namespace and the rules act as simple annotation classes only parsing configuration. Rewrote tests and added a FilterLoader in the mix to help find the proper class to handle a rule. This also makes it possible create new rules that use 'services' to apply themselves.
Adding Callback filter skeleton
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a work in progress.
The main goal of this version is to rewrite all the annotations to properly separate annotations from actual filters. It also deal with new Symfony versions and new events.
Track progress here: https://github.com/rdohms/DMS/issues?milestone=4&state=open