VPAAMP-651: Trickplay skips incorrectly at cdai ad boundaries#1674
Open
varshnie wants to merge 1 commit into
Open
VPAAMP-651: Trickplay skips incorrectly at cdai ad boundaries#1674varshnie wants to merge 1 commit into
varshnie wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CDAI trickplay position jumps at ad-boundary discontinuities by ensuring the MP4 demuxer’s trickmode PTS restamping state machine transitions correctly even when discontinuous init segments yield no samples (preventing incorrect cross-period PTS deltas).
Changes:
- Adds a helper to pre-advance trickmode restamp state on discontinuities.
- Invokes the helper when a discontinuous init segment in trickplay produces no samples (CDAI boundary case).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mp4demux/AampMp4Demuxer.h |
Declares HandleTrickModeDiscontinuity() helper for trickmode discontinuity handling. |
mp4demux/AampMp4Demuxer.cpp |
Implements the helper and calls it from sendSegment() for discontinuous init segments with no samples. |
Reason for change:Init segments at ad boundaries carry discontinuity flag but yield no samples,leaving state machine in STEADY phase. Next ad data segment computes incorrect PTS delta, causing catastrophic position jump to stream end. Risks: p1 Signed-off-by: varshnie <varshniblue14@gmail.com>
varshnie
force-pushed
the
feature/VPAAMP-651
branch
from
8fc661a to
c607fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Init segments at ad boundaries carry discontinuity flag but yield no samples,leaving state machine in STEADY phase. Next ad data segment computes incorrect PTS delta, causing catastrophic position jump to stream end.
Risks: p1
Signed-off-by: varshnie varshniblue14@gmail.com