VPLAY-12744:Handle static DASH DRM license rotation using EAP#1664
Open
varshnie wants to merge 3 commits into
Open
VPLAY-12744:Handle static DASH DRM license rotation using EAP#1664varshnie wants to merge 3 commits into
varshnie wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the DASH MPD fragment collector to detect non-VSS Early Available Periods (EAP) in live manifests and pre-queue DRM content protection (license prefetch/rotation path), guarded by a new config flag.
Changes:
- Introduces
processLicenseFromEAPconfig and wires manifest processing to callProcessLicenseFromEAP()for live MPDs. - Adds
GetEarlyAvailablePeriods()detection + queues content protection for the detected early period’s adaptation sets. - Extends unit-test infrastructure (mocks/fakes + new test cases) to validate early-period detection and license queueing behavior.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
AampConfig.h |
Adds new bool config enum eAAMPConfig_ProcessLicenseFromEAP. |
AampConfig.cpp |
Registers processLicenseFromEAP in bool lookup table. |
fragmentcollector_mpd.h |
Declares ProcessLicenseFromEAP() and GetEarlyAvailablePeriods(). |
fragmentcollector_mpd.cpp |
Calls ProcessLicenseFromEAP() during live manifest metadata processing; implements early-period detection + queueing; adds a safety guard in GetLanguageForAdaptationSet() for empty representation lists. |
test/utests/mocks/MockAampLicManager.h |
Adds mock APIs for queueContentProtection() / queueProtectionEvent(). |
test/utests/mocks/MockDrmHelper.h |
Adds global mock handle for DRM helper use in fakes/tests. |
test/utests/fakes/FakeAampLicManager.cpp |
Forwards queue operations to MockAampLicenseManager when present. |
test/utests/fakes/FakeDRMHelper.cpp |
Allows DrmHelperEngine to return a mocked DRM helper (test seam). |
test/utests/tests/StreamAbstractionAAMP_MPD/FunctionalTests.cpp |
Adds tests for early-period detection and license queueing; sets up license manager + DRM helper mocks. |
test/utests/tests/StreamAbstractionAAMP_MPD/subtitleTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/StreamSelectionTest.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/LinearFOGTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/FetcherLoopTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/AudioTrackSwitchTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/AudioTrackSelectionTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/StreamAbstractionAAMP_MPD/AudioOnlyTests.cpp |
Adds default entry for new config in bool config settings. |
test/utests/tests/FragmentCollectorAdTests/AdSelectionTests.cpp |
Adds default entry for new config in bool config settings. |
8960c1f to
4f523be
Compare
Vinish100
reviewed
Jun 29, 2026
4f523be to
c3102a9
Compare
Vinish100
reviewed
Jun 30, 2026
Reason for change:Adding the support to detect EarlyAvailablePeriod to Queue Content Protection Risks: Medium Signed-off-by: varshnie <varshniblue14@gmail.com>
c3102a9 to
beafaeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Adding the support to detect EarlyAvailablePeriod to Queue Content Protection
Risks: Medium
Signed-off-by: varshnie varshniblue14@gmail.com