[Actions] Fix a bug with diff showing up due to path mismatch#292
Conversation
There was a problem hiding this comment.
Pull request overview
Updates several generator GitHub Actions workflows to prevent false-positive diffs caused by mismatched root paths in unified diff headers, improving the accuracy of PR preview diff rendering.
Changes:
- Normalizes unified diff
---/+++file header paths by stripping differing roots (e.g.,baseline/,generated/, variant-specific roots). - Applies the same normalization approach across ProxyStub, Lua, JSON, and PluginSkeleton generator workflows.
- Keeps the existing diff generation flow intact (diff creation → optional diff2html rendering), but post-processes the diff text before evaluation/rendering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/ProxyStubGenerator.yml | Normalizes diff header paths in diffs/combined.diff to avoid path-mismatch diffs. |
| .github/workflows/PluginSkeletonGenerator.yml | Normalizes per-variant diff header paths in diffs/${name}.diff to avoid path-mismatch diffs. |
| .github/workflows/LuaGenerator.yml | Normalizes diff header paths in diffs/combined.diff to avoid path-mismatch diffs. |
| .github/workflows/JsonGenerator.yml | Normalizes diff header paths in diffs/combined.diff to avoid path-mismatch diffs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LuaGenerator ResultsNo changes detected. |
|
Plugin skeleton preview (latest run): No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output. |
LuaGenerator ResultsNo changes detected. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
|
Plugin skeleton preview (latest run): No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
No description provided.