Allow duplicate event names#279
Merged
Merged
Conversation
sebaszm
commented
Jun 9, 2026
sebaszm
commented
Contributor
- fix )) syntax typo
- fix mutable default arg
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the code generators/parsers to (1) avoid a mutable default argument in the C++ parser include reader, (2) fix a C++ emission syntax typo, and (3) permit duplicate event names during JSON schema generation by disambiguating clashing event identifiers.
Changes:
- Fix mutable default argument in
CppParser.ReadFile()by switchinginclusionsdefault toNone. - Fix an extra
)in generated C++ for hex decoding inrpc_emitter.py. - Adjust event-name clash handling in
header_loader.pyto allow duplicates (currently via#suffixing).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ProxyStubGenerator/CppParser.py | Reworks ReadFile() default argument handling for inclusions. |
| JsonGenerator/source/rpc_emitter.py | Fixes emitted C++ syntax for hex decoding boolean result. |
| JsonGenerator/source/header_loader.py | Changes event clash logic to allow duplicate event names by renaming on collision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LuaGenerator ResultsNo changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.