-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use BlankNode according to RDF/JS spec #335
Conversation
Uh, why did the tests fail? They work fine locally here |
Spec tests are not part of the unit tests, have you run |
Yes, all pass locally. |
@tpluscode - it looks like the problem was that the
incorrectly asserts that the result should be empty when the result in the file is indeed |
Can you do that? |
@RubenVerborgh - can you re-run the CI on this or give me access to do so? |
@jeswr Did both 👍 |
Closing in favour of #346 |
What is the timeline for v2? A simple one-liner could still make it to 1.16.x, surely? 🙏 |
Aiming for this week; and the breaking changes should not require any changes in most consumers (it changes the semantics of parsing Will make a patch release with this regardless. |
Fixed in 1.16.4 |
Fixes #334
When parsing n3 rule, the parse tries to access
.id
of a term which is not according to spec and fails when alternative factory is provided, such as@rdfjs/data-model
. This PR's change is to the.value
property instead