Permit sending "rich" content via notify
#355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the RPC "Notify" event to carry a full MOO "Var" instead of a string, along with a content-type. The builtin function "notify" is now modified to take an optional third argument, which is a content / mime-type. The intent here is to allow cores & clients connected to them to do smarter things with richer content. For default (no argument), or for any content-type which starts with "text/" the 2nd argument is expected to be a MOO string, same as usual, and E_TYPE is raised for any other value types. For any other content type, the value is allowed to be passed through without modification and is up to the client to interpret it. The existing telnet client just turns everything into strings, relying on the default .to_string functionality on Var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the RPC "Notify" event to carry a full MOO
Varinstead of only a string, along with an optional content-type.The builtin function "notify" is now modified to take an optional third argument, which is a content / mime-type. The intent here is to allow cores & clients connected to them to do smarter things with richer content.
For default (no argument), or for any content-type which starts with "text/" the 2nd argument is expected to be a MOO string, same as usual, and E_TYPE is raised for any other value types.
For any other content type, the value is allowed to be passed through without modification and is up to the client to interpret it.
The existing telnet client just turns everything into strings, relying on the default .to_string functionality on Var.