VM refactoring #351
Merged
VM refactoring #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea here being that we will have different kinds of activation frames. MOO verb frames, builtin frames, and in the future, frames from other languages. "Frame" here being the language/runtime-specific portion of a given activation record.
In this way "builtin" frames become our first "non-MOO" frame. Reflecting _roughly_ how we'll do non-MOO interpreters in the future. More work on stack unwinding and error handling needs to be done here, but this is a start.
* Move builtins off of "VM" and up onto their own BuiltinRegistry which is owned by the Scheduler and passed around. * Begin dispatch into the "right" kind of "VM" (builtin func or MOO) inside the VMHost instead of inside the MOO VM.
Dispatch of MOO stack frames is done through a simple function call.
Make decode and preparation of activation frames aware of the binary type though only MOO is supported at this time.
- Some renames to better reflect what's going on inside vm/ - Remove an unnecessary Arc for each builtin function, and use Box instead. - Formatting and stuff
* These came over from LambdaMOO opcodes list, but aren't even really used there. * They're redundant and just the same as PUT/PUSH * At some point we'll introduce more sophisticated scoping constructs and these will just get in the way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits which are part of some long overdue reworking of the verb dispatch and execution happens for both the MOO virtual machine and for builtins.
One part of this is about making things more consistent in interface for builtins vs MOO execution, and cleaning up the builtin execution so they happen in their own frame type.
Another part is moving the bulk of execution logic off of the MOO "VM" and onto the VMExecState, and then isolating the MOO specific portions to their own routine, which operates on MooFrames only.
All of this has the eventual goal of making it easier to support other language runtimes inside the
moorsystem.