-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactoring of Scheduler/Task #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdaum
force-pushed
the
rd/scheduler-refactor
branch
from
June 26, 2024 21:22
8ca1e2e
to
6cc434e
Compare
Highlights: * Suspended tasks no longer hog a thread and idle. Instead their thread ends and they are moved into a suspended vector inside the scheduler itself. * Tasks that start in a delayed state (e.g. forks) now no longer use a thread with a manual delay. Instead they begin their life in suspended state and are picked up by the scheduler tick. * Gut the remainder of the complicated dispatch logic that was leftover from the old async/tokio version of this code. Intermediate result objects (which used to be processed in batch) are gone, and actions are immediately acted on. This should be a lot easier to read now. I believe this paves the way for a more testable, robust future.
rdaum
force-pushed
the
rd/scheduler-refactor
branch
from
June 26, 2024 21:24
6cc434e
to
28f480b
Compare
* Run simple program to completion * Throw an exception * `suspend()` and resume * `read()`` and resume * fork
rdaum
force-pushed
the
rd/scheduler-refactor
branch
from
June 27, 2024 02:43
8f70c72
to
68b0f62
Compare
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
abesto
reviewed
Jun 27, 2024
rdaum
force-pushed
the
rd/scheduler-refactor
branch
from
June 27, 2024 21:25
936c177
to
17acb3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Sorry this one is going to be hard to read as any kind of diff. If you're worried, I recommend just reading the whole of scheduler.rs and task.rs. **
Highlights:
I believe this paves the way for a more testable, robust future.