Skip to content

Indexing, part 2

Indexing, part 2 #337

Triggered via push February 19, 2024 18:25
Status Success
Total duration 3m 0s
Artifacts

rust-buiild.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
this expression creates a reference which is immediately dereferenced by the compiler: crates/db/src/rdb/index/im_hash_index.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/db/src/rdb/index/im_hash_index.rs:91:47 | 91 | let Some(tuples) = self.index.get_mut(&key) else { | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
redundant pattern matching, consider using `is_ok()`: crates/db/src/rdb/tx/working_set.rs#L647
warning: redundant pattern matching, consider using `is_ok()` --> crates/db/src/rdb/tx/working_set.rs:647:20 | 647 | if let Ok(_) = self | ^^^^^ | = note: this will change drop order of the result, as well as all temporaries = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default help: try | 647 ~ if self 648 + .domain_index 649 + .unindex_tuple(&del_tuple.domain(), del_tuple.id()).is_ok() |
this boolean expression can be simplified: crates/db/src/rdb/tx/working_set.rs#L651
warning: this boolean expression can be simplified --> crates/db/src/rdb/tx/working_set.rs:651:20 | 651 | if !self.tx_tuple_events.remove(&del_tuple.id()).is_some() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tx_tuple_events.remove(&del_tuple.id()).is_none()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.