Use List instead of Vec<Var> throughout #283
rdaumAnnotations
4 warnings
|
check_license
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
use of a fallible conversion when an infallible one could be used:
crates/rpc/rpc-common/src/lib.rs#L341
warning: use of a fallible conversion when an infallible one could be used
--> crates/rpc/rpc-common/src/lib.rs:341:28
|
341 | let pub_key: Key<32> = Key::try_from(public_key.to_bytes())
| ^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `[u8; 32]` to `Key<32>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
|
use of a fallible conversion when an infallible one could be used:
crates/rpc/rpc-common/src/lib.rs#L339
warning: use of a fallible conversion when an infallible one could be used
--> crates/rpc/rpc-common/src/lib.rs:339:29
|
339 | let priv_key: Key<64> = Key::try_from(private_key.to_keypair_bytes())
| ^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `[u8; 64]` to `Key<64>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
crates/common/src/var/list.rs#L229
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> crates/common/src/var/list.rs:229:1
|
229 | impl Into<Var> for List {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<var::list::List>`
|
229 ~ impl From<List> for Var {
230 ~ fn from(val: List) -> Self {
231 ~ Var::from_variant(Variant::List(val))
|
|