Skip to content

Adds a new "flyweight" type - a lightweight object #258

Adds a new "flyweight" type - a lightweight object

Adds a new "flyweight" type - a lightweight object #258

Triggered via push December 8, 2024 02:07
Status Success
Total duration 1m 30s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

1 error and 4 warnings
you are deriving `Hash` but have implemented `PartialEq` explicitly: crates/common/src/var/flyweight.rs#L66
error: you are deriving `Hash` but have implemented `PartialEq` explicitly --> crates/common/src/var/flyweight.rs:66:17 | 66 | #[derive(Clone, Hash, PartialOrd, Ord, Eq)] | ^^^^ | note: `PartialEq` implemented here --> crates/common/src/var/flyweight.rs:77:1 | 77 | impl PartialEq for Inner { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq = note: `#[deny(clippy::derived_hash_with_manual_eq)]` on by default = note: this error originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
usage of an `Arc` that is not `Send` and `Sync`: crates/common/src/var/flyweight.rs#L207
warning: usage of an `Arc` that is not `Send` and `Sync` --> crates/common/src/var/flyweight.rs:207:28 | 207 | let fl = Flyweight(Arc::new(fi)); | ^^^^^^^^^^^^ | = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
usage of an `Arc` that is not `Send` and `Sync`: crates/common/src/var/flyweight.rs#L165
warning: usage of an `Arc` that is not `Send` and `Sync` --> crates/common/src/var/flyweight.rs:165:14 | 165 | Self(Arc::new(Inner { | ______________^ 166 | | delegate, 167 | | slots: slots.into(), 168 | | contents, 169 | | seal, 170 | | })) | |__________^ | = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
redundant pattern matching, consider using `is_some()`: crates/common/src/var/flyweight.rs#L146
warning: redundant pattern matching, consider using `is_some()` --> crates/common/src/var/flyweight.rs:146:16 | 146 | if let Some(_) = &self.0.seal { | -------^^^^^^^--------------- help: try: `if self.0.seal.is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
check_license
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636