Skip to content

Adds a new "flyweight" type - a lightweight object #328

Adds a new "flyweight" type - a lightweight object

Adds a new "flyweight" type - a lightweight object #328

Triggered via push December 8, 2024 02:06
Status Success
Total duration 6m 5s
Artifacts

format-check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 5 warnings
you are deriving `Hash` but have implemented `PartialEq` explicitly: crates/common/src/var/flyweight.rs#L52
error: you are deriving `Hash` but have implemented `PartialEq` explicitly --> crates/common/src/var/flyweight.rs:52:17 | 52 | #[derive(Clone, Hash, PartialOrd, Ord, Eq)] | ^^^^ | note: `PartialEq` implemented here --> crates/common/src/var/flyweight.rs:63:1 | 63 | impl PartialEq for Inner { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq = note: `#[deny(clippy::derived_hash_with_manual_eq)]` on by default = note: this error originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
usage of an `Arc` that is not `Send` and `Sync`: crates/common/src/var/flyweight.rs#L193
warning: usage of an `Arc` that is not `Send` and `Sync` --> crates/common/src/var/flyweight.rs:193:28 | 193 | let fl = Flyweight(Arc::new(fi)); | ^^^^^^^^^^^^ | = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
usage of an `Arc` that is not `Send` and `Sync`: crates/common/src/var/flyweight.rs#L151
warning: usage of an `Arc` that is not `Send` and `Sync` --> crates/common/src/var/flyweight.rs:151:14 | 151 | Self(Arc::new(Inner { | ______________^ 152 | | delegate, 153 | | slots: slots.into(), 154 | | contents, 155 | | seal, 156 | | })) | |__________^ | = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
redundant pattern matching, consider using `is_some()`: crates/common/src/var/flyweight.rs#L132
warning: redundant pattern matching, consider using `is_some()` --> crates/common/src/var/flyweight.rs:132:16 | 132 | if let Some(_) = &self.0.seal { | -------^^^^^^^--------------- help: try: `if self.0.seal.is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
style
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style
Unexpected input(s) 'dprint-version', valid inputs are ['entryPoint', 'args']