Split various web handlers out into their own source units, as web_ho… #266
Annotations
15 warnings
accessing first element with `pair.get(0)`:
crates/web-host/src/host/mod.rs#L132
warning: accessing first element with `pair.get(0)`
--> crates/web-host/src/host/mod.rs:132:31
|
132 | let key = pair.get(0).ok_or(JsonParseError::InvalidRepresentation)?;
| ^^^^^^^^^^^ help: try: `pair.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
function `verb_invoke_handler` is never used:
crates/web-host/src/host/verbs.rs#L17
warning: function `verb_invoke_handler` is never used
--> crates/web-host/src/host/verbs.rs:17:14
|
17 | pub async fn verb_invoke_handler(
| ^^^^^^^^^^^^^^^^^^^
|
function `json_as_var` is never used:
crates/web-host/src/host/mod.rs#L99
warning: function `json_as_var` is never used
--> crates/web-host/src/host/mod.rs:99:8
|
99 | pub fn json_as_var(j: &serde_json::Value) -> Result<Var, JsonParseError> {
| ^^^^^^^^^^^
|
variants `UnknownType`, `UnknownError`, and `InvalidRepresentation` are never constructed:
crates/web-host/src/host/mod.rs#L92
warning: variants `UnknownType`, `UnknownError`, and `InvalidRepresentation` are never constructed
--> crates/web-host/src/host/mod.rs:92:5
|
90 | pub enum JsonParseError {
| -------------- variants in this enum
91 | #[error("Unknown type")]
92 | UnknownType,
| ^^^^^^^^^^^
93 | #[error("Unknown error")]
94 | UnknownError,
| ^^^^^^^^^^^^
95 | #[error("Invalid representation")]
96 | InvalidRepresentation,
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `JsonParseError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
unused import: `serde_json::json`:
crates/web-host/src/host/web_host.rs#L33
warning: unused import: `serde_json::json`
--> crates/web-host/src/host/web_host.rs:33:5
|
33 | use serde_json::json;
| ^^^^^^^^^^^^^^^^
|
unused import: `serde_derive::Deserialize`:
crates/web-host/src/host/web_host.rs#L32
warning: unused import: `serde_derive::Deserialize`
--> crates/web-host/src/host/web_host.rs:32:5
|
32 | use serde_derive::Deserialize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused imports: `EntityType`, `PropInfo`, `VerbInfo`, and `VerbProgramResponse`:
crates/web-host/src/host/web_host.rs#L29
warning: unused imports: `EntityType`, `PropInfo`, `VerbInfo`, and `VerbProgramResponse`
--> crates/web-host/src/host/web_host.rs:29:29
|
29 | use rpc_common::{AuthToken, EntityType, PropInfo, VerbInfo, VerbProgramResponse};
| ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^
|
unused import: `moor_values::tasks::VerbProgramError`:
crates/web-host/src/host/web_host.rs#L25
warning: unused import: `moor_values::tasks::VerbProgramError`
--> crates/web-host/src/host/web_host.rs:25:5
|
25 | use moor_values::tasks::VerbProgramError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `Form`:
crates/web-host/src/host/web_host.rs#L21
warning: unused import: `Form`
--> crates/web-host/src/host/web_host.rs:21:12
|
21 | use axum::{Form, Json};
| ^^^^
|
unused import: `HeaderValue`:
crates/web-host/src/host/web_host.rs#L19
warning: unused import: `HeaderValue`
--> crates/web-host/src/host/web_host.rs:19:29
|
19 | use axum::http::{HeaderMap, HeaderValue, StatusCode};
| ^^^^^^^^^^^
|
unused import: `json_as_var`:
crates/web-host/src/host/web_host.rs#L16
warning: unused import: `json_as_var`
--> crates/web-host/src/host/web_host.rs:16:25
|
16 | use crate::host::{auth, json_as_var, var_as_json};
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
crates/kernel/src/tasks/task.rs#L558
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/kernel/src/tasks/task.rs:558:6
|
558 | ) -> Result<Option<((Bytes, VerbDef), Objid)>, CommandError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
match expression looks like `matches!` macro:
crates/kernel/src/tasks/scheduler.rs#L388
warning: match expression looks like `matches!` macro
--> crates/kernel/src/tasks/scheduler.rs:388:36
|
388 | let need_tx_oref = match vloc {
| ____________________________________^
389 | | ObjectRef::Id(_) => false,
390 | | _ => true,
391 | | };
| |_________________^ help: try: `!matches!(vloc, ObjectRef::Id(_))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
|
style
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style
Unexpected input(s) 'dprint-version', valid inputs are ['entryPoint', 'args']
|