Skip to content

Exclude checked-in flexbuffers from dprint check #257

Exclude checked-in flexbuffers from dprint check

Exclude checked-in flexbuffers from dprint check #257

Triggered via push October 16, 2024 12:42
Status Success
Total duration 5m 37s
Artifacts

format-check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
this expression creates a reference which is immediately dereferenced by the compiler: crates/daemon/src/rpc_server.rs#L606
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/daemon/src/rpc_server.rs:606:39 | 606 | args.iter().map(|s| v_str(&s)).collect(), | ^^ help: change this to: `s` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
very complex type used. Consider factoring parts into `type` definitions: crates/kernel/src/tasks/task.rs#L558
warning: very complex type used. Consider factoring parts into `type` definitions --> crates/kernel/src/tasks/task.rs:558:6 | 558 | ) -> Result<Option<((Bytes, VerbDef), Objid)>, CommandError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
returning the result of a `let` binding from a block: crates/kernel/src/tasks/scheduler.rs#L406
warning: returning the result of a `let` binding from a block --> crates/kernel/src/tasks/scheduler.rs:406:21 | 402 | / let vloc = match vloc { 403 | | ObjectRef::Id(id) => id, 404 | | _ => panic!("Unexpected object reference in vloc"), 405 | | }; | |______________________- unnecessary `let` binding 406 | vloc | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 402 ~ 403 ~ match vloc { 404 + ObjectRef::Id(id) => id, 405 + _ => panic!("Unexpected object reference in vloc"), 406 + } |
match expression looks like `matches!` macro: crates/kernel/src/tasks/scheduler.rs#L388
warning: match expression looks like `matches!` macro --> crates/kernel/src/tasks/scheduler.rs:388:36 | 388 | let need_tx_oref = match vloc { | ____________________________________^ 389 | | ObjectRef::Id(_) => false, 390 | | _ => true, 391 | | }; | |_________________^ help: try: `!matches!(vloc, ObjectRef::Id(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `#[warn(clippy::match_like_matches_macro)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/web-host/src/host/mod.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/web-host/src/host/mod.rs:70:52 | 70 | serde_json::Value::String(s) => Some(v_str(&s)), | ^^ help: change this to: `s` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
function `verb_invoke_handler` is never used: crates/web-host/src/host/web_host.rs#L454
warning: function `verb_invoke_handler` is never used --> crates/web-host/src/host/web_host.rs:454:14 | 454 | pub async fn verb_invoke_handler( | ^^^^^^^^^^^^^^^^^^^
function `json_as_var` is never used: crates/web-host/src/host/mod.rs#L67
warning: function `json_as_var` is never used --> crates/web-host/src/host/mod.rs:67:8 | 67 | pub fn json_as_var(j: &serde_json::Value) -> Option<Var> { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
the borrowed expression implements the required traits: crates/moot/src/lib.rs#L247
warning: the borrowed expression implements the required traits --> crates/moot/src/lib.rs:247:37 | 247 | runner.eval(player, &format!("{command} \"moot-line:{line_no}\";")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{command} \"moot-line:{line_no}\";")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/values/src/model/mod.rs#L66
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/values/src/model/mod.rs:66:49 | 66 | values_flatbuffers::moor::values::Uuid::new(&uuid.as_bytes()) | ^^^^^^^^^^^^^^^^ help: change this to: `uuid.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of `unwrap_or_else` to construct default value: crates/values/src/model/verbdef.rs#L158
warning: use of `unwrap_or_else` to construct default value --> crates/values/src/model/verbdef.rs:158:14 | 158 | .unwrap_or_else(Vec::new) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
style
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
style
Unexpected input(s) 'dprint-version', valid inputs are ['entryPoint', 'args']