Incremental improvements in the web server/client #235
rdaumAnnotations
8 warnings
|
style
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
style
Unexpected input(s) 'dprint-version', valid inputs are ['entryPoint', 'args']
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
crates/daemon/src/rpc_server.rs#L606
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/daemon/src/rpc_server.rs:606:39
|
606 | args.iter().map(|s| v_str(&s)).collect(),
| ^^ help: change this to: `s`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
crates/web-host/src/host/mod.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/web-host/src/host/mod.rs:70:52
|
70 | serde_json::Value::String(s) => Some(v_str(&s)),
| ^^ help: change this to: `s`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
function `verb_invoke_handler` is never used:
crates/web-host/src/host/web_host.rs#L454
warning: function `verb_invoke_handler` is never used
--> crates/web-host/src/host/web_host.rs:454:14
|
454 | pub async fn verb_invoke_handler(
| ^^^^^^^^^^^^^^^^^^^
|
|
function `json_as_var` is never used:
crates/web-host/src/host/mod.rs#L67
warning: function `json_as_var` is never used
--> crates/web-host/src/host/mod.rs:67:8
|
67 | pub fn json_as_var(j: &serde_json::Value) -> Option<Var> {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
returning the result of a `let` binding from a block:
crates/kernel/src/tasks/scheduler.rs#L406
warning: returning the result of a `let` binding from a block
--> crates/kernel/src/tasks/scheduler.rs:406:21
|
402 | / let vloc = match vloc {
403 | | ObjectRef::Id(id) => id,
404 | | _ => panic!("Unexpected object reference in vloc"),
405 | | };
| |______________________- unnecessary `let` binding
406 | vloc
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
402 ~
403 ~ match vloc {
404 + ObjectRef::Id(id) => id,
405 + _ => panic!("Unexpected object reference in vloc"),
406 + }
|
|
|
match expression looks like `matches!` macro:
crates/kernel/src/tasks/scheduler.rs#L388
warning: match expression looks like `matches!` macro
--> crates/kernel/src/tasks/scheduler.rs:388:36
|
388 | let need_tx_oref = match vloc {
| ____________________________________^
389 | | ObjectRef::Id(_) => false,
390 | | _ => true,
391 | | };
| |_________________^ help: try: `!matches!(vloc, ObjectRef::Id(_))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
|