validation-patient-nhs-number

[eatyourpeas]

Add validation in the clean method to the patient form

• if nhs_number is present, check if does not already exists
• if urn is present, check if does not already exist
  already exists

In both of these circumstances it raises a validation error.

this now breaks most of the tests because it causes an async error

Other things:

1. fix for the headers in the patient table. Reorganises the filtering so that those patients that have not completed a full year or died now come at the bottom and have a dark blue header
2. fix the hovertext console non-critical error relating to pyplot
3. reorganise the deprivation colours so that pink and red are deprived, blue and green are not

[eatyourpeas]

@mbarton not sure if this is going to work if we validate in this way? In this PR I have added ValidationErrors for existing NHS Numbers or URN. This works fine in the questionnaire but now breaks the CSV upload with an async error the fails in this new validation step. Is it that it thinks each row is a new patient, even through it is only the visit that is new?

[mbarton]

Ah i see. The error is just that you can’t use sync database calls in an async function. Django mandates this to avoid inadvertent blocking.

We could maybe do some sync_to_async wrapping as we have elsewhere. But I’m wondering if it’s better just to get on and implement Celery. With multiple workers we would not need async at all.

[eatyourpeas]

I agree - do you want to pair on it on Thursday? I added aexists in the form as an experiment and it worked except then it broke further down as nhs_number was now missing from cleaned_data.