Skip to content

Commit

Permalink
Merge pull request #570 from shannonmitchell/JIRA/REO-REO-343
Browse files Browse the repository at this point in the history
Fixes Glance & Cinder API Version Check Issue
  • Loading branch information
tonytan4ever authored Oct 9, 2018
2 parents 26971fa + bfd07d7 commit 57a3999
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
6 changes: 3 additions & 3 deletions playbooks/files/rax-maas/plugins/maas_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
'OS_ENDPOINT_TYPE': 'PublicURL',
'OS_IDENTITY_API_VERSION': None,
'OS_API_INSECURE': False,
'OS_VOLUME_API_VERSION': None,
'OS_IMAGE_API_VERSION': None, }
'OS_VOLUME_API_VERSION': 1,
'OS_IMAGE_API_VERSION': 1}

if 'Ubuntu' in platform.linux_distribution()[0]:
AUTH_DETAILS.update({
Expand Down Expand Up @@ -668,7 +668,7 @@ def get_auth_details(openrc_file=OPENRC, maasrc_file=MAASRC):
continue
k = match.group('key')
v = match.group('value').strip('"').strip("'")
if k in auth_details and auth_details[k] is None:
if k in auth_details:
auth_details[k] = v
except IOError as e:
if e.errno != errno.ENOENT:
Expand Down
7 changes: 7 additions & 0 deletions releasenotes/notes/fix-glance-cinder-api-version-issue.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- The maas_common.py is setting OS_VOLUME_API_VERSION and
OS_IMAGE_API_VERSION with a default of None. This caused
calls to get_auth_details to fail a key check for 'None'
causing nova and neutron checks to fail of those variables
are not being set in the environment anywhere.

0 comments on commit 57a3999

Please sign in to comment.