Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements fixup #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Grinnz
Copy link

@Grinnz Grinnz commented Sep 8, 2021

  1. Move the contents of PoeBuildInfo.pm into Makefile.PL, the only place it is used, to remove the layer of misdirection when debugging the build process.
  2. Use the -f 'META.yml' hack from Distar to keep dynamic deps from being added while authoring, so that they don't show up in the static deps. This is possibly preventing POE from being installed on Windows, where IO::Tty does not install. Unfortunately without switching to a proper separated authoring tool, this is the best option I can think of for making the distinction between author and install time.
  3. Quote versions of requirements, because module versions are strings (trailing zeroes are significant, avoid floating point errors, etc)

@Getty
Copy link

Getty commented Sep 8, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants