-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major refactoring: process and split data properly, save splitted data #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is to completely get rid of utils/process_generations)
…flow, and standardises across pipelines)
…ts match (important for tf-idf versus metrics clf)
… the eval fails if the text is too long, in those cases e.g., dailymail + stories, we truncate to 1024 and compute perplexity from that)
…ots in utils for now
…tted scaler and pca)
…and loading a fitted PCA and scaler, black/isort formatting
…a, beluga generations for the same id are in the same split).
MinaAlmasi
changed the title
major refactoring: split data properly
major refactoring: process and split data properly, save splitted data
Oct 14, 2024
This was referenced Oct 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/utils
e.g.,process_generations
andprocess_metrics
that were used EVERYWHERE and instead did this processing ONCE (see point 4)src/utils/process_X
scripts to scripts insrc/make_dataset
where both text and metrics datasets are created in identicaltrain
,val
,test
splits and saved todatasets_complete
(closing issue Create script to split data for classifiers and save to folder #70)check_datasets
to check thatmake_dataset/text_dataset.py
andmake_dataset/metrics_dataset.py
make identical splits in terms of ID/MODEL (important for comparison between XGBOOST and TFIDF)6.Renamed
datasets
todatasets_files
to complement newly addeddatasets_complete
folder to handle the distinction between the individual files (generatedtext
and extractedmetrics
) and the combined, splitted data (train/val/testtext
andmetrics
)src/pca
andsrc/classify
) to handle new datasetsmetrics/heatmaps.py
for ECHO presentation)Future
New feats:
Refactoring:
PCA
splits (right now they are transformed prior to classification)src/utils
to their respective folder if not used in multiple places