Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format the code #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Format the code #98

wants to merge 2 commits into from

Conversation

wilsoncheung7
Copy link

Just formatted the code, no important changes.

@gitolicious
Copy link
Collaborator

I don't think it's a good idea to commit any .idea files. Also we should agree on a specific formatter as especially max line width is handled differently across formatters and individual settings. Otherwise we will end up in an edit war.

@rbignon, what do you think?

@rbignon
Copy link
Owner

rbignon commented Jul 10, 2021

Hello,

Yes, we will not include any IDE specific files for a light python script like doctoshotgun.

@wilsoncheung7
The original authors have already applied prototype design, which it …
3c630c1 
…is one of the creational patterns. In this case, I rearranged the code and changed two class variables values of the class called DoctolibFR. I will explain more detail in the report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilsoncheung7 @gitolicious @rbignon