Introduce "with_bundled_gems" build step for dev rubies and unify "standard" #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
changed the title
This merges "standard_build" and "standard_install" build steps into one again and modifies "standard_install_with_bundled_gems" to just invoke "standard" with the addition of `update-gems` & `extract-gems` targets.
mislav
force-pushed
the
with-bundled-gems
branch
from
a836533
to
c534618
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges "standard_build" and "standard_install" build steps into one again and defines a "standard_install_with_bundled_gems" build step that just invokes "standard" with the addition of
update-gems&extract-gems.The goal is to have a single
standardstep again instead of maintaining it as two distinctbuild_package_standard_buildandbuild_package_standard_installfunctions.A runtime difference that will be a result of this change is that three separate invocations
make update-gems,make extract-gems, andmake installare now executed as one:make update-gems extract-gems install./cc @hsbt as this reverts parts of #1098