feat: OTPInput field value clear behaviour changes #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabilansakthivelu
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315,
saurabhdaware and
tewarig
as code owners
🦋 Changeset detectedLatest commit: 0be0e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0be0e5a:
|
|
Hi, thanks for the PR. This looks great. I'll just get it reviewed from our design team and update here. |
saurabhdaware
previously approved these changes
Feb 7, 2025
saurabhdaware
added
Review - L2
anuraghazra
previously approved these changes
Feb 7, 2025
anuraghazra
dismissed stale reviews from saurabhdaware and themself
via
0be0e5a
anuraghazra
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In OTPInput, when a value is cleared in one of the input field, persisting the focus in the same input field instead of shifting the focus to previous input field
Changes
Current behaviour:
When user wants to update a particular input field value in OTPInput component, the focus gets shifted to previous input field on clearing the value and user have to shift to the corresponding input field again to enter the updated value
Screen.Recording.2025-02-04.at.15.43.43.mov
Changes made:
When
BackspaceorDeletekey is pressed on an input field in OTPInput component,Screen.Recording.2025-02-04.at.15.41.19.mov
Additional Information
Component Checklist