feat: remove overflowY if L1 sidenav is collapsed #2523
Conversation
anuraghazra
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
snitin315,
saurabhdaware and
tewarig
as code owners
🦋 Changeset detectedLatest commit: 0df6340 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0df6340:
|
| @@ -348,12 +348,29 @@ const NavItem = ( | |||
| ); | |||
| }; | |||
|
|
|||
| const Logo = ({ isNavCollapsed }: { isNavCollapsed?: boolean }): React.ReactElement => { | |||
There was a problem hiding this comment.
intentional to add this? it's a bit of hack because we don't have TopNav no? so do we need this in docs?
Also check other stories once if this example is used there. In those stories it might end up adding 2 logos one on sidenav and one on topnav
There was a problem hiding this comment.
Right will remove this i think.
| @@ -355,6 +355,11 @@ const _SideNav = ( | |||
| onVisibleLevelChange?.({ visibleLevel: 2 }); | |||
| }, L1_EXIT_HOVER_DELAY); | |||
| } | |||
| // If L1 is collapsed and not hovered we want to change visible level to 2 | |||
| // This state/edgecase happens when user clicks on a nested nav and it collapses the L1 causing isL1Hovered to be false | |||
| if (isL1Collapsed && !isL1Hovered) { | |||
There was a problem hiding this comment.
Didn't understand this scenario, Can you share screenrecording?
The level isn't changing in this scneario no?
There was a problem hiding this comment.
Screen.Recording.2025-02-05.at.4.41.00.PM.mov
…/blade into anu/sidenav-hide-scroll
Bundle Size ReportUpdated Components
|
Description
Changes
Additional Information
Component Checklist