Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Avatar): add missing ref on default avatar #2516

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

saurabhdaware
Copy link
Member

@saurabhdaware saurabhdaware commented Jan 31, 2025

Description

Ref was missing on one of the if blocks of Avatar which caused Menu to not work

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: b1f1ef3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Jan 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1f1ef3:

Sandbox Source
razorpay/blade: basic Configuration

anuraghazra
anuraghazra previously approved these changes Jan 31, 2025
@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
BladeProvider 1.707 1.709 +0.002 KB

Generated by 🚫 dangerJS against b1f1ef3

@saurabhdaware saurabhdaware merged commit 8b5602b into master Jan 31, 2025
11 of 14 checks passed
@saurabhdaware saurabhdaware deleted the fix/avatar-menu-integration branch January 31, 2025 11:28
tewarig pushed a commit that referenced this pull request Feb 5, 2025
* fix(Avatar): add missing ref on default avatar

* Create nasty-frogs-end.md
tewarig added a commit that referenced this pull request Feb 7, 2025
* feat/chat-bubble-api-decision

* chore: api docs

* chore: update is user message

* fix: typo

* feat: updated decisions

* chore: more changes

* chore: update decision and chatBubble

* feat: done with right message

* feat: response message

* feat: api changes

* chore: add motion

* feat: add animation and update some props

* chore: code refactor

* chore: updated docs for chatbubble

* chore: update width

* chore: more refactor

* fix: getStringFromReactText from utils

* feat: add style props

* feat: add message

* chore: added more example

* feat: add types

* feat: added ref

* feat: update types and example

* chore: more ts and other changes

* chore: update decision.md

* chore: update ray icon

* chore: update snops

* chore: add more tests

* feat: add sort and prompt icon [p0] (#2511)

* feat: add sort and cherry pick icons

* chore: add changeset

* chore: change sort

* fix: more lint changes

* chore: few changes

* chore: sort icon

* chore: remove path

* chore: update changeset

* build(blade): update version (#2512)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(Avatar): add missing ref on default avatar (#2516)

* fix(Avatar): add missing ref on default avatar

* Create nasty-frogs-end.md

* build(blade): update version (#2518)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: add chatbubble

* chore: minior review changes

* chore: more review changes

* chore: typescript gymnastics

* chore: use Meta constans

* chore: remove lazy motion

* chore: added jsDoc comments

* chore: added tokens

* chore: update comments

* chore: remove stringChildType and change export

* chore: fix another error

* chore: added wrapper component

* chore: more changes

* chrore: add footer actions

* chore: update tests and snap

* feat: more tests

* fix: add should add padding

* chore: add typing animation

* chore: file name refactor , new animation

* chore:sender type

* chore: removed max width

* chore: update docs

* chore: chatMessage refactor

* chore: update snaps

* chore: fix ts

* chore: more changes

* feat: chatMessage

* chore: docs update

* chore: update snaps

* chore: update example

* chore: change styledPropsBlade to BaseBoxProps

* fix: types

* chore: added more types

* chore: import type

* chore: change types and footer spacing

* chore: update snaps

* chore: more changes

* chore: reverse rfc change

* chore: update test

* chore: update snap and wrapper

* chore: update web snap

* chore: add make box props

* feat: update snaps

* chore: more changes

* chore: update type and example

---------

Co-authored-by: rzpcibot <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Saurabh Daware <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants