feat: table virtualization #2489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… color in hover actions
| <TableHeaderCell headerKey="STATUS">Status </TableHeaderCell> | ||
| </TableHeaderRow> | ||
| </TableHeader> | ||
| <TableBody<Item>> |
| /** | ||
| * isVirtualized prop determines whether the table is virutalized or not. | ||
| */ | ||
| isVirtualized?: boolean; |
There was a problem hiding this comment.
we can internally handle this without taking from consumer
| isVirtualized = false, | ||
| ...rest | ||
| }: TableProps<Item>, | ||
| ref: React.Ref<BladeElementRef> | undefined, |
There was a problem hiding this comment.
We can remove ref and use height and calculate the width height of table node itself
<Box ref={parentRef}>
<Table parentRef={parentRef} />
</Box><Table height="" />| {tableItem.status} | ||
| </Badge> | ||
| </TableCell> | ||
| </TableRow> |
There was a problem hiding this comment.
checked VirtualizedTable does not support footer. we can only pass header and footer. also can't think of a case where we will be using VirtualizedTable with footer.
packages/blade/src/components/Table/docs/BasicTable.stories.tsx
Outdated
Show resolved
Hide resolved
packages/blade/src/components/Table/docs/BasicTable.stories.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional Information
dev checklist -
[ x ] vtable height be changed
[ x ] check why check box look weird ?
[ x ] need to make row similar to normal table
[ x ] should check the space of table.
[ x ] vtable should be aligned as normal table.
[ x ] hover actions
[ x ] sticky column
[ x ] table header
[ x ] fix ts error
[ x ] unified styles for virtualized table
[ x ] add tests
Component Checklist