Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Changed the iOS version to 16.0 as per requirements #698

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Changed the iOS version to 16.0 as per requirements #698

merged 4 commits into from
Aug 18, 2023

Conversation

NikitaShvadlenko
Copy link
Contributor

Fixing a readme issue #678
Changed the version from 13.3 to 16.0 in readme, as described in the link and in this pull request: #679

Thank you:)

sammyd
sammyd previously approved these changes Aug 14, 2023
Copy link
Collaborator

@sammyd sammyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@NikitaShvadlenko
Copy link
Contributor Author

Hello again :)
What can I do for the checks not to fail?
I see that there is an error with unwrapping Content, but I did not change anything related to Content.

@NikitaShvadlenko
Copy link
Contributor Author

NikitaShvadlenko commented Aug 15, 2023

Update: I noticed that all test failures are related to unwrapping Content, so I added guard statements in tests.
Also there was a problem with ContentAdapter, it was returning nil, but it looks like it was supposed to throw an error (ContentAdapterTest for the wrong content-type request), so I changed it to throw an error.
__
I am still a bit confused on how the tests were not working on the development branch.
I would really appreciate your feedback on whether I did the correct thing and an explanation about how the tests were failing (I am really new to git checks).

Thank you <3

@NikitaShvadlenko
Copy link
Contributor Author

Update: I realised that the content was returning as optional, because of the error in the ContentAdapter - it was meant to throw an error instead of returning nil, when the content-type is wrong.
So I reverted the commit with guard statements in tests and only left the commit with changing the return type in the ContentAdapter.

Copy link
Collaborator

@sammyd sammyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't really understand how tests passed on development either, but this seems ok to me :)

Thank you so much!

@sammyd sammyd merged commit 00a0722 into razeware:development Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants